Skip to content

Implement the Custom Endpoint Plugin #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Nov 7, 2024
Merged

Implement the Custom Endpoint Plugin #727

merged 28 commits into from
Nov 7, 2024

Conversation

@aaron-congo
Copy link
Contributor

@aaron-congo aaron-congo commented Oct 30, 2024

Description

  • as custom endpoints are used, monitor threads are created to monitor custom endpoint information
  • custom endpoint information is fetched using the RDS API, so users of the CustomEndpointPlugin need to have the boto3 AWS Python SDK
  • connections register their plugin services with a given monitor if they are connecting to that monitor's custom endpoint
  • when the monitor detects changes in custom endpoint information, it updates the custom endpoint information for all registered plugins
  • added new methods in PluginService to get/set allowed/blocked hosts according to custom endpoint information, and to fetch the current list of hosts that are allowed by the custom endpoint plugin. The failover and read/write plugin use this subset of hosts when deciding which host to switch to

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaron-congo aaron-congo changed the title Custom endpoint Implement the Custom Endpoint Plugin Oct 31, 2024
aaron-congo
aaron-congo commented Oct 31, 2024
View reviewed changes
aws_advanced_python_wrapper/read_write_splitting_plugin.py
Comment on lines +266 to +267
hostnames = [host_info.host for host_info in hosts]
if self._reader_host_info is not None and self._reader_host_info.host not in hostnames:
Copy link
Contributor Author

@aaron-congo aaron-congo Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will hit this block whenever read_only is set to True. Are there performance concerns for this block? It is necessary to protect against the case where we have previously cached a reader instance connection but that reader instance was later removed from the custom endpoint. Without this check the read/write plugin would continue to use the cached reader connection to the now-blocked instance.

@aaron-congo aaron-congo merged commit 61f696e into main Nov 7, 2024
5 checks passed
@aaron-congo aaron-congo deleted the custom-endpoint branch November 7, 2024 22:58
@karthich karthich mentioned this pull request Nov 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergiyvamz sergiyvamz sergiyvamz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaron-congo @sergiyvamz